feat: add agentcore banner to CLI - #2223
Draft
nborges-aws wants to merge 2 commits into
Draft
Conversation
agentcore-devx-automation
Bot
added
agentcore-harness-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
claude-security-reviewing
![agentcore-devx-automation[bot]](https://avatars.githubusercontent.com/u/2232217?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Nice, self-contained addition. I read through BrandBanner, Layout, RouterScreen, Badge, and GradientText and didn't find anything that needs to change before merge.
A few small observations that are not blockers — mentioning only in case they're useful:
src/components/ui/badge/Badge.tsx: theborderStylemixes rounded (╭,╯) with square (┐,└) corners. If that mismatch is intentional, ignore; if not, you probably want all four corners to be the same style (e.g. all rounded viaborderStyles.roundedfrom_core.ts).src/components/ui/badge/Badge.tsx:labelis only.toUpperCase()'d whenchildrenis a plain string.<Badge>v{PACKAGE_VERSION}</Badge>passes an array of JSX children and stays lowercase, while<Badge>{v${PACKAGE_VERSION}}</Badge>would get uppercased. The current test happens to exercise the first form, but this is a subtle footgun for future callers.src/components/ui/gradient-text/GradientText.tsx:interpolateGradientColordoesn't clamppositionto[0, 1]. Current callers stay in-range (index / max(1, span-1)withindex < span), so it's fine today; worth clamping if this becomes a shared utility.- No telemetry is added, which seems appropriate here since this is a purely decorative banner with no new user action to instrument.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2223 +/- ##
=========================================
Coverage 97.05% 97.05%
=========================================
Files 555 560 +5
Lines 38385 38480 +95
=========================================
+ Hits 37253 37348 +95
Misses 1132 1132 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending final banner design - will flip PR to ready upon alignment
Description
Add banner to start page of agentcore CLI. Also includes version badge. Currently set to "AgentCore CLI" and "v1.0.0"
Changes:
GradientTextcomponent to handle gradient styling of bannerExample
{video incoming}
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.